Validate XTCE output #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test that will validate the generated oresat xtce against the official xtce schema. This caught three minor issues in our generator: - The root `name` attribute doesn't like dots in its string. 63f8766 broke this when refactoring the mission names, this restores the old behavior. - The XML namespace was incorrect. It pointed to the old version of XTCE which had been changed in the new schema. It also required `xtce` to be the prefix for every tag, which we weren't doing. Dropping it means the whole document is assumed to be in that namespace so we don't have to go through the hassle of prefixing every tag. - Encodings -> Encoding. The schema check in CI could be more elegant, I've just hardcoded both fetching the schema and the output file for now but they probably should be determined dynamically eventually.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that will validate the generated oresat xtce against the official xtce schema. This caught three minor issues in our generator:
nameattribute doesn't like dots in its string. 63f8766 broke this when refactoring the mission names, this restores the old behavior.xtceto be the prefix for every tag, which we weren't doing. Dropping it means the whole document is assumed to be in that namespace so we don't have to go through the hassle of prefixing every tag.The schema check in CI could be more elegant, I've just hardcoded both fetching the schema and the output file for now but they probably should be determined dynamically eventually.