Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[faq] 🇮🇹 Added italian FAQ pages #217

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

lucaceccarini
Copy link
Contributor

Added FAQ pages in italian language.

Signed-off-by: Luca Ceccarini [email protected]

Signed-off-by: Luca Ceccarini <[email protected]>
Copy link
Collaborator

@gpesquero gpesquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaceccarini: Please remove these dots

@gpesquero
Copy link
Collaborator

@lucaceccarini: You must also add in the config.toml file the following keys in the [languages.it.translations] section:

engines = "Motori TTS supportati"
faq-menu-title = "Domande frequenti"
language-word = "Lingua"

(Please confirm the translation to Italian)

Copy link
Collaborator

@gpesquero gpesquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaceccarini: Please add localized slug for better SEO

@lucaceccarini
Copy link
Contributor Author

@lucaceccarini: You must also add in the config.toml file the following keys in the [languages.it.translations] section:

Done. Completely missed that, thanks!

content/faq/_index.it.md Outdated Show resolved Hide resolved
@@ -0,0 +1,17 @@
---
title: Quali versioni di iOS e Android sono supportate?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People recommend using quotes for special characters: https://stackoverflow.com/a/22235064

lucaceccarini and others added 2 commits March 15, 2024 10:58
Co-authored-by: Alexander Borsuk <[email protected]>
Signed-off-by: Luca Ceccarini <[email protected]>
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@biodranik biodranik merged commit 5613ad0 into organicmaps:master Mar 15, 2024
1 of 2 checks passed
@gpesquero
Copy link
Collaborator

Hi again @lucaceccarini: We have forgotten to translate also the names of the taxonomies, so the "App" and "Voice instructions" sections in the FAQ list and in the FAQ top menu are still displayed in English:

italian1

italian2

These translations shall be done in the "faq" field included in the header of each of the new .md files:

---
title: Text-to-Speech su Android
description: Guida su come far funzionare il TTS su Android
slug: text-to-speech-su-android

taxonomies:
  faq: ["Voice Directions"]      << Translate this !!

extra:
  order: 10
---

Please launch an additional PR with this translations, or you can provide the Italian translation of "App" and "Voice instructions" and I can launch the PR myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants