Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate page tokens for better error codes #4021

Merged
merged 5 commits into from
Sep 2, 2024

test: update assertions

97cea84
Select commit
Loading
Failed to load commit list.
Merged

fix: validate page tokens for better error codes #4021

test: update assertions
97cea84
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 27, 2024 in 1s

78.37% (target 70.00%)

View this Pull Request on Codecov

78.37% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (7945104) to head (97cea84).

Files Patch % Lines
persistence/sql/identity/persister_identity.go 0.00% 1 Missing and 1 partial ⚠️
persistence/sql/persister_session.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
- Coverage   78.39%   78.37%   -0.02%     
==========================================
  Files         370      370              
  Lines       26127    26133       +6     
==========================================
  Hits        20481    20481              
- Misses       4088     4092       +4     
- Partials     1558     1560       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.