Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: Add required "group(kvm)" for openQA-worker #5968

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

okurz
Copy link
Member

@okurz okurz commented Oct 1, 2024

openSUSE Factory since about 20240928 seems to need an explicit addition
of the "kvm" group. This commit tries to fix that same as we do with
"nogroup".

Related progress issue: https://progress.opensuse.org/issues/167587

openSUSE Factory since about 20240928 seems to need an explicit addition
of the "kvm" group. This commit tries to fix that same as we do with
"nogroup".

Related progress issue: https://progress.opensuse.org/issues/167587
@okurz
Copy link
Member Author

okurz commented Oct 1, 2024

@Vogtinator @DimStar77 can you say if this is the right approach to fix

usermod: group 'kvm' does not exist

in the openSUSE Factory build or do you have another suggestion?

@Vogtinator
Copy link
Member

sysusers.d says: Add a user to a group. If the user or group do not exist yet, they will be implicitly created.

@DimStar77
Copy link
Contributor

Ensuring the group is properly pulled in when using it does sound correct to me

@Vogtinator
Copy link
Member

So arguably a bug in whatever reads the sysusers.d file there, but IMO requiring the proper group is the better option.

We can't use the RPM native sysusers.d support and sysuser-tools doesn't generate requires, so I think this is the correct fix.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (d5e5ab9) to head (1acf501).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5968      +/-   ##
==========================================
- Coverage   98.75%   98.75%   -0.01%     
==========================================
  Files         396      396              
  Lines       38966    38966              
==========================================
- Hits        38482    38479       -3     
- Misses        484      487       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit b638ad7 into os-autoinst:master Oct 1, 2024
45 checks passed
@okurz okurz deleted the fix/pkg branch October 1, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants