Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry setting up the postgres container #84

Merged
merged 1 commit into from
May 11, 2022

Conversation

kalikiana
Copy link
Member

@kalikiana kalikiana force-pushed the setup_env_posthres_podman_retry branch from c6ac496 to bda8f51 Compare May 11, 2022 12:04
@perlpunk
Copy link
Contributor

Did you do a verification run?

@kalikiana
Copy link
Member Author

kalikiana commented May 11, 2022

Did you do a verification run?

Yes. But apparently install_deps.sh is never run: https://openqa.opensuse.org/tests/2339622#step/setup_env/7

@perlpunk
Copy link
Contributor

it probably needs to be installed the same way as docker in tests/install/openqa_webui.pm

assert_script_run("zypper --non-interactive install docker git", timeout => 600);

@kalikiana
Copy link
Member Author

it probably needs to be installed the same way as docker in tests/install/openqa_webui.pm

assert_script_run("zypper --non-interactive install docker git", timeout => 600);

That makes a lot of sense in hindsight since it's run as part of the test 🤦🏾 Thanks

@kalikiana kalikiana force-pushed the setup_env_posthres_podman_retry branch from bda8f51 to a9bd402 Compare May 11, 2022 13:25
@kalikiana kalikiana force-pushed the setup_env_posthres_podman_retry branch from a9bd402 to 3a2760d Compare May 11, 2022 13:46
@kalikiana
Copy link
Member Author

That makes a lot of sense in hindsight since it's run as part of the test 🤦🏾 Thanks

Successful verification run: https://openqa.opensuse.org/tests/2339705

@Martchus
Copy link
Contributor

Although it is likely worthwhile to implement 2c858a1#r870361065=.

@kalikiana kalikiana mentioned this pull request May 11, 2022
@kalikiana
Copy link
Member Author

Perhaps #86 is a cleaner option

@okurz okurz merged commit e881ac1 into master May 11, 2022
@okurz okurz deleted the setup_env_posthres_podman_retry branch May 11, 2022 15:06
@okurz
Copy link
Member

okurz commented May 11, 2022

This looks fine and I prefer it over #86 which can't work within os-autoinst-distri-openQA anyway.

@kalikiana
Copy link
Member Author

This looks fine and I prefer it over #86 which can't work within os-autoinst-distri-openQA anyway.

It does work. Please keep an open mind when I am trying something out which takes about as much time as the whole conversation 😃

Anyway fine by me to go with this version.

@okurz
Copy link
Member

okurz commented May 11, 2022

Yes, you fixed it by including a valid definition of script_retry now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants