Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use podman everywhere #85

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use podman everywhere #85

wants to merge 1 commit into from

Conversation

kalikiana
Copy link
Member

@kalikiana kalikiana commented May 11, 2022

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change but I would like to see a proof that this works.

@kalikiana kalikiana force-pushed the use_podman_everywhere branch 5 times, most recently from 79c0f49 to 5847ea1 Compare May 16, 2022 23:05
@kalikiana
Copy link
Member Author

I like the change but I would like to see a proof that this works.

It works, but I wonder why podman build times out so easily. Is this normal and just hidden behind retries? There's a timeout of 3600 and it seems to simply take longer getting all of the packages installed.

Comment on lines -10 to +11
assert_script_run("for i in {1..3}; do docker run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --net-alias=db --name db postgres && break; done", timeout => 600);
wait_for_container_log("db", "database system is ready to accept connections", "docker");
assert_script_run($self->{cre} . " network create testing");
assert_script_run($self->{cre} . " run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --network-alias=db --name db docker.io/library/postgres:latest", timeout => 600);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you are reverting the retrying you added just recently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see it in the diff, but likely this was a timeout I mistakenly added when I didn't know where it was timing out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But … you removed the retrying, see the diff please. The for i in {1..3}; … is gone

kalikiana added a commit to kalikiana/openQA that referenced this pull request May 18, 2022
We already use it in some but not in other cases. Being explicit avoids
surprises and stops podman from asking to choose one.

See also os-autoinst/os-autoinst-distri-openQA#85
Comment on lines -10 to +11
assert_script_run("for i in {1..3}; do docker run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --net-alias=db --name db postgres && break; done", timeout => 600);
wait_for_container_log("db", "database system is ready to accept connections", "docker");
assert_script_run($self->{cre} . " network create testing");
assert_script_run($self->{cre} . " run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --network-alias=db --name db docker.io/library/postgres:latest", timeout => 600);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But … you removed the retrying, see the diff please. The for i in {1..3}; … is gone

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

This pull request is now in conflicts. Could you fix it? 🙏

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

This pull request is now in conflicts. Could you fix it? 🙏

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

This pull request is now in conflicts. Could you fix it? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants