wicked: add config parsing tests #20193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacerus
reviewed
Sep 13, 2024
| cat - <<-EOT | ||
|
|
||
| Infiniband configuration parsing checks. | ||
| * see: https://gitlab.suse.de/wicked-maintainers/wicked/-/wikis/infiniband-names |
There was a problem hiding this comment.
Is there a publicly accessible link which could be used here to make the explanation useful for external contributors as well?
There was a problem hiding this comment.
Not now, it could be the ipoib manpage, but not so detailed with all these examples and possibilities. Maybe we should just public this list in github wiki as well 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config parsing tests for
Verification run:
Set to draft, as I think we should wait till fix of bsc#1229555 should be released to SLES as well