Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various enhancement #1597

Merged
merged 4 commits into from
May 22, 2024
Merged

Various enhancement #1597

merged 4 commits into from
May 22, 2024

Conversation

chungshien-chai
Copy link
Collaborator

@chungshien-chai chungshien-chai commented May 22, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

  1. For set_clock_pin, use the auto-generated SDC from extractor
  2. Do not use FCLK path for routing CC pin to fabric
  • Existing solution had been proven working on flop design simulation
  • But found a new path where we can route the CC pin via gearbox RX_clock_IO feature
  • This new path save FCLK resource(s)
  • But need to re-test flop design

Coverage failed because currently we do not have unit test that cover Compiler code to compile a project

Testing done:

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 14.60%. Comparing base (3b53761) to head (f778bfc).
Report is 80 commits behind head on main.

Files Patch % Lines
src/Compiler/CompilerOpenFPGA.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
- Coverage   14.62%   14.60%   -0.02%     
==========================================
  Files         475      475              
  Lines       62572    62555      -17     
  Branches    25353    25313      -40     
==========================================
- Hits         9152     9139      -13     
+ Misses      52305    52294      -11     
- Partials     1115     1122       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alaindargelas alaindargelas merged commit 8532ef3 into main May 22, 2024
33 of 35 checks passed
@alaindargelas alaindargelas deleted the foedag-set-clock-pin branch May 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants