Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lie algebras: more progress #4053
Lie algebras: more progress #4053
Changes from 15 commits
9e026a9
c98f49c
1c04c58
d8720f9
143a322
73d4ea5
90ca8c3
8d46710
9d281a2
de18baa
ea5aef0
ef94ec7
972c8ff
47e70cc
a3d8640
49f1eb5
1f6ba6d
e7611d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 10 in experimental/LieAlgebras/src/CoxeterGroup.jl
Codecov / codecov/patch
experimental/LieAlgebras/src/CoxeterGroup.jl#L10
Check warning on line 14 in experimental/LieAlgebras/src/CoxeterGroup.jl
Codecov / codecov/patch
experimental/LieAlgebras/src/CoxeterGroup.jl#L14
Check warning on line 18 in experimental/LieAlgebras/src/CoxeterGroup.jl
Codecov / codecov/patch
experimental/LieAlgebras/src/CoxeterGroup.jl#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to specify this at this point, as I want to straight out all of the return types in the near future. That's also the reason for the many `The return type will change in the future" in docstrings.