-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lie algebras: more progress #4053
Conversation
c9f266e
to
3640a14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4053 +/- ##
==========================================
+ Coverage 84.64% 84.76% +0.11%
==========================================
Files 612 614 +2
Lines 83250 83966 +716
==========================================
+ Hits 70469 71170 +701
- Misses 12781 12796 +15
|
3640a14
to
cd9043c
Compare
18f00d5
to
972c8ff
Compare
Co-authored-by: Max Horn <[email protected]>
@@ -1431,11 +1431,65 @@ function dim_of_simple_module(L::LieAlgebra, hw::Vector{<:IntegerUnion}) | |||
end | |||
|
|||
@doc raw""" | |||
dominant_character(L::LieAlgebra{C}, hw::Vector{Int}) -> Dict{Vector{Int}, Int} | |||
dominant_weights([T,] L::LieAlgebra{C}, hw::Vector{<:IntegerUnion}) -> Vector{T} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dominant_weights([T,] L::LieAlgebra{C}, hw::Vector{<:IntegerUnion}) -> Vector{T} | |
dominant_weights([T = Vector{Int}], L::LieAlgebra{C}, hw::Vector{<:IntegerUnion}) -> Vector{T} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to specify this at this point, as I want to straight out all of the return types in the near future. That's also the reason for the many `The return type will change in the future" in docstrings.
Co-authored-by: Felix Röhrich <[email protected]>
Co-authored-by: Felix Röhrich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Contains the following changes/additions:
isomorphism(FPGroup, ::WeylGroup)
via Coxeter relations. Already known information likeis_finite
andorder
gets set in the result as well to allow for better handling in GAP.dot(::WeightLatticeElem, ::WeightLatticeElem)
dominant_character
,character
, andtensor_product_decomposition
now use the root system, if available, and only fall back to GAP otherwise. (@benlorenz this should resolve the rest of cases of Make LieAlgebraModule tests better gc-able #3913 (comment))This is still a draft since I would like to wait for #4036 to get merged first to avoid conflicts.