BasisLieHighestWeight: Replace GAP uses by Oscar functionality #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is the default in `basis_lie_highest_weight`. This has not been an issue in the cases that were compared previously.
lgoettgens
added
WIP
instead of `Vector{ZZRingElem}`.
Only minimal clean-up performed yet.
to not change output right now
lgoettgens
force-pushed
the
lg/blhw-use-oscar-types
branch
from
22fe6f6
to
bc8887b
Compare
lgoettgens
force-pushed
the
lg/blhw-use-oscar-types
branch
from
bc8887b
to
2eec36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. use
WeightLatticeElemandRootSpaceElemfor weights and roots (instead ofVector{ZZRingElem}), and remove the need for theLieAlgebraStructurewrapper aroundAbstractLieAlgebra.Still WIP. The PR is only open to check the book tests.