Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasisLieHighestWeight: Replace GAP uses by Oscar functionality #4322

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

BasisLieHighestWeight: Replace GAP uses by Oscar functionality #4322

wants to merge 16 commits into from

Commits on Nov 14, 2024

  1. Fix reference test to use degrevlex ordering 

    Since this is the default in `basis_lie_highest_weight`. This has not been an issue in the cases that were compared previously.
    @lgoettgens
    lgoettgens committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    71966c4 View commit details
    Browse the repository at this point in the history

  2. Rename some vars to contain _gap

    @lgoettgens
    lgoettgens committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    75efd2d View commit details
    Browse the repository at this point in the history

  3. Change Lie algebra construction from GAP to OSCAR

    @lgoettgens
    lgoettgens committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    51b7b12 View commit details
    Browse the repository at this point in the history

  4. Move iso calls around

    @lgoettgens
    lgoettgens committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    deb2e8f View commit details
    Browse the repository at this point in the history

  5. Change cartan matrix from GAP to OSCAR

    @lgoettgens
    lgoettgens committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4f717dd View commit details
    Browse the repository at this point in the history

  6. Change character from GAP to OSCAR

    @lgoettgens
    lgoettgens committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    78b8af0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Change operator index calculations from GAP to OSCAR

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d263a24 View commit details
    Browse the repository at this point in the history

  2. Change dim_of_simple_module from GAP to OSCAR

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f75eb1b View commit details
    Browse the repository at this point in the history

  3. Use specialized types for roots and weights 

    instead of `Vector{ZZRingElem}`.
Only minimal clean-up performed yet.
    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3503122 View commit details
    Browse the repository at this point in the history

  4. Use roots as operators instead of GAP.Obj

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9e09e13 View commit details
    Browse the repository at this point in the history

  5. Some cleanup

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    06d1ef3 View commit details
    Browse the repository at this point in the history

  6. Rewrite compute_sub_weights

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3eb76a4 View commit details
    Browse the repository at this point in the history

  7. Some optimization

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3ccee10 View commit details
    Browse the repository at this point in the history

  8. Workaround show functions 

    to not change output right now
    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    040d518 View commit details
    Browse the repository at this point in the history

  9. Excise LieAlgebraStructure

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    130f780 View commit details
    Browse the repository at this point in the history

  10. Format

    @lgoettgens
    lgoettgens committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2eec36d View commit details
    Browse the repository at this point in the history