Update Utils.kt #86
Merged
Update Utils.kt #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Certainly for the time being this is not a breaking change. The project is essentially using Kotlin rules at the moment so fixing them is fine. In a future release the project does need to implement proper Swift rules. |
|
Fixed lint error. |
|
hm not sure whats wrong with CI? At first I had a format issue but now not sure... |
|
The new failure is not your fault. It has to do with permissions given to actions. I need to update the workflow to work with outside PR's again. |
|
gotcha thanks! |
|
Hi @kdubb was hoping to push this forward if it looks good! Thanks again! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #85
@kdubb I didnt think about it too much for the rest of the project tbh...I do not see this being a breaking change?