Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mrc): headers props accept ReactNode #14579

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tristanwagner
Copy link
Contributor

@tristanwagner tristanwagner commented Dec 13, 2024

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #14570
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@tristanwagner tristanwagner self-assigned this Dec 13, 2024
@tristanwagner tristanwagner requested review from a team as code owners December 13, 2024 15:22
@github-actions github-actions bot added the bug Something isn't working label Dec 13, 2024
@tristanwagner tristanwagner linked an issue Dec 13, 2024 that may be closed by this pull request
1 task
@sachinrameshn sachinrameshn self-requested a review December 16, 2024 08:54
ref: 14570

Signed-off-by: Tristan WAGNER <[email protected]>
Comment on lines +6 to +8
title?: ReactNode;
subtitle?: ReactNode;
description?: ReactNode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss with DEsign team if we need to make ReactNode for title, subtitle & decsription.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update about this @anooparveti ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[manager-components]: Change props title on headers component
5 participants