Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mrc): headers props accept ReactNode #14579

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(mrc): headers props accept ReactNode #14579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/manager-react-components/src/components/content/headers/headers.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import React from 'react';
import React, { ReactNode } from 'react';
import { OdsText } from '@ovhcloud/ods-components/react';
import { Title, Subtitle } from '../../typography';

export interface HeadersProps {
title?: string;
subtitle?: string;
description?: string;
headerButton?: React.ReactElement;
title?: ReactNode;
subtitle?: ReactNode;
description?: ReactNode;
headerButton?: ReactNode;
Comment on lines +6 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss with DEsign team if we need to make ReactNode for title, subtitle & decsription.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update about this @anooparveti ?

}

export const Headers: React.FC<HeadersProps> = ({
Expand Down
Loading