Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] add API tests for file download and rename edge cases #9018

Merged
merged 8 commits into from
May 2, 2024
Merged

[tests-only] add API tests for file download and rename edge cases #9018

merged 8 commits into from
May 2, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Apr 30, 2024 •
edited
Loading

Description

Added the following scenarios:

Scenario: try to download recently deleted file
Scenario Outline: rename a folder
Scenario Outline: rename folder to/from special characters
Scenario Outline: try to rename folder to name having white space at the end
Scenario Outline: try to rename folder to same name
Scenario Outline: rename a folder to existing folder name
Scenario Outline: try to rename folder to . and ..

Taken from owncloud/web#10861

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Apr 30, 2024
This was referenced Apr 30, 2024
Merged
Closed
@saw-jan saw-jan force-pushed the tests/extend-download-test branch from 48d297f to b3cc01c Compare May 2, 2024 04:49
@saw-jan saw-jan marked this pull request as ready for review May 2, 2024 04:52
@saw-jan saw-jan changed the title [tests-only] add API tests for trying to download deleted file [tests-only] add API tests for file download and rename edge cases May 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ScharfViktor
ScharfViktor approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit 5c7c363 into master May 2, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/extend-download-test branch May 2, 2024 06:36
ownclouders pushed a commit that referenced this pull request May 2, 2024
@saw-jan
[tests-only] add API tests for file download and rename edge cases (#…
2c0ed5e 
…9018)

* test: add API tests to download deleted file

* test: add more MOVE/rename API tests

* do not reuse step def method

* remove unused step

* fix typo

* fix tests

* update expected failure

* update expected failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @ScharfViktor