Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop support for old acceptance tests #10259

Closed
17 of 18 tasks
ScharfViktor opened this issue Jan 3, 2024 · 15 comments
Closed
17 of 18 tasks

Stop support for old acceptance tests #10259

ScharfViktor opened this issue Jan 3, 2024 · 15 comments
Assignees
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Jan 3, 2024

2 years ago, we stopped implement old acceptance tests and started using e2e with playwright.
Now we want to:

  • delete all unworkable, repetitive, irrelevant tests
  • rewrite useful tests
  • close all issues related acceptance tests

Steps:

@ScharfViktor
Copy link
Contributor Author

CC @saw-jan

@amrita-shrestha
Copy link
Contributor

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not #10481. Otherwise, my PR will be stuck for a long time.

@ScharfViktor
Copy link
Contributor Author

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not #10481. Otherwise, my PR will be stuck for a long time.

Sorry, how this task is related to #10481 ?

@saw-jan
Copy link
Member

saw-jan commented Mar 5, 2024

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not #10481. Otherwise, my PR will be stuck for a long time.

Let's run /journeys/kindergarten.feature with the keycloak for now, then we can go on to include more tests.
CC @amrita-shrestha @ScharfViktor

@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented Mar 6, 2024

cc @PrajwolAmatya @Salipa-Gurung @saw-jan currently facing problems while running keycloak tests in drone ci. IMO it will be nice to check locally whether keycloak-related tests pass or not #10481. Otherwise, my PR will be stuck for a long time.

Sorry, how this task is related to #10481 ?

If we add some scenario/step on space.feature and journey then maybe that step needs refactoring to work on ocis-keycloak. I am not saying to check all scenario/step. Just step/scenario which falls under keycloak tests(currently journey/space.feature).

@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented Apr 9, 2024

@saw-jan @Salipa-Gurung @PrajwolAmatya can we close this issue #7264 or we going to let it open?

@PrajwolAmatya PrajwolAmatya removed their assignment Apr 23, 2024
@saw-jan saw-jan self-assigned this Apr 30, 2024
@saw-jan
Copy link
Member

saw-jan commented May 17, 2024

@ScharfViktor Let's close this one.
The only thing remaining is to cleanup in ocis drone config but that should be done along with the web bump to ocis

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor Let's close this one. The only thing remaining is to cleanup in ocis drone config but that should be done along with the web bump to ocis

Yes, I close it, but before I wanted to clean up ocis CI

@ScharfViktor
Copy link
Contributor Author

closed as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants