Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] split apiSharingNg test features to different suites #9523

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Jul 4, 2024

Description

This PR covers the test for checking if the CI time will be reduced if we split the apiSharingNg and apiSharingNgLinkShare suite into two. So:

  • separated all the link related tests from apiSharingNg suite and put them inside another suite apiSharingNg2 suite while renaming apiSharingNg to apiSharingNg1.
  • separated all the tests using permissions endpoint and root endpoint from apiSharingNgLinkShare suite and put them inside:
      - apiSharingNgLinkSharePermission for tests using permissions endpoint
      - apiSharingNgLinkShareRoot for tests using root endpoint

Note

The naming of the suite is given so because to maintain the name's length not exceed 50 characters long. Because of this:

# check if name length of pipeline and steps are exceeded.
   max_name_length = 50
   for pipeline in pipelines:
       pipeline_name = pipeline["name"]
       if len(pipeline_name) > max_name_length:
           print("Error: pipeline name %s is longer than 50 characters" % (pipeline_name))

       for step in pipeline["steps"]:
          step_name = step["name"]
           if len(step_name) > max_name_length:
               print("Error: step name %s in pipeline %s is longer than 50 characters" % (step_name, pipeline_name))

inside drone.star file

Related Issue

Motivation and Context

  • To check the CI run-time reduction

How Has This Been Tested?

  • test environment:
  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@anon-pradip anon-pradip force-pushed the test/split-apiSharingNg-suite-for-CI-time-check branch 14 times, most recently from 51a4c6c to a89edc1 Compare July 8, 2024 09:12
@anon-pradip anon-pradip force-pushed the test/split-apiSharingNg-suite-for-CI-time-check branch 13 times, most recently from 401dc6d to 0f10d11 Compare July 8, 2024 10:59
drone Outdated Show resolved Hide resolved
@anon-pradip anon-pradip force-pushed the test/split-apiSharingNg-suite-for-CI-time-check branch from ba82ee0 to e7e4da9 Compare July 9, 2024 08:54
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/36885/51/5

runsh: Total unexpected failed scenarios throughout the test run:
coreApiWebdavPreviews/previews.feature:234

Looks like an unrelated test fail. I will restart CI.

@saw-jan saw-jan changed the title [tests-only][full-ci] test: remove link-related tests from apiSharingNg suite for checking if CI time gets reduced [tests-only][full-ci] split apiSharingNg test features to different suites Jul 9, 2024
Comment on lines +91 to +92
"apiSharingNgLinkSharePermission",
"apiSharingNgLinkShareRoot",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"apiSharingNgLinkSharePermission",
"apiSharingNgLinkShareRoot",
"apiSharingNgPermissions",
"apiSharingNgRoot",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But doing this, won't it make a little bit difficult to distinguish for link share test scenarios? Like: using the suites name apiSharingNgLinkSharePermission makes it more clear that it is related to link share. 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests are only link share then it's good 👍

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, rebase the PR

@anon-pradip anon-pradip force-pushed the test/split-apiSharingNg-suite-for-CI-time-check branch from e7e4da9 to ff9a80f Compare July 10, 2024 07:21
Copy link

sonarcloud bot commented Jul 10, 2024

@phil-davis phil-davis merged commit 9b00f7b into master Jul 10, 2024
4 checks passed
@phil-davis phil-davis deleted the test/split-apiSharingNg-suite-for-CI-time-check branch July 10, 2024 08:05
ownclouders pushed a commit that referenced this pull request Jul 10, 2024
…for-CI-time-check

[tests-only][full-ci] split apiSharingNg test features to different suites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants