-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] split apiSharingNg test features to different suites #9523
[tests-only][full-ci] split apiSharingNg test features to different suites #9523
Conversation
51a4c6c
to
a89edc1
Compare
401dc6d
to
0f10d11
Compare
ba82ee0
to
e7e4da9
Compare
https://drone.owncloud.com/owncloud/ocis/36885/51/5
Looks like an unrelated test fail. I will restart CI. |
"apiSharingNgLinkSharePermission", | ||
"apiSharingNgLinkShareRoot", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"apiSharingNgLinkSharePermission", | |
"apiSharingNgLinkShareRoot", | |
"apiSharingNgPermissions", | |
"apiSharingNgRoot", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But doing this, won't it make a little bit difficult to distinguish for link share test scenarios? Like: using the suites name apiSharingNgLinkSharePermission
makes it more clear that it is related to link share. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests are only link share then it's good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, rebase the PR
e7e4da9
to
ff9a80f
Compare
Quality Gate passedIssues Measures |
…for-CI-time-check [tests-only][full-ci] split apiSharingNg test features to different suites
Description
This PR covers the test for checking if the CI time will be reduced if we split the apiSharingNg and apiSharingNgLinkShare suite into two. So:
apiSharingNg
suite and put them inside another suiteapiSharingNg2
suite while renamingapiSharingNg
toapiSharingNg1
.permissions endpoint
androot endpoint
fromapiSharingNgLinkShare
suite and put them inside:-
apiSharingNgLinkSharePermission
for tests usingpermissions endpoint
-
apiSharingNgLinkShareRoot
for tests usingroot endpoint
Note
The naming of the suite is given so because to maintain the name's length not exceed 50 characters long. Because of this:
inside
drone.star
fileRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: