Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] split apiSharingNg test features to different suites #9523

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[tests-only][full-ci] split apiSharingNg test features to different suites #9523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .drone.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,11 @@ config = {
"apiLocks",
"apiSearch1",
"apiSearch2",
"apiSharingNg",
"apiSharingNg1",
"apiSharingNg2",
"apiSharingNgShareInvitation",
"apiSharingNgLinkShare",
"apiSharingNgLinkSharePermission",
"apiSharingNgLinkShareRoot",
Comment on lines +91 to +92
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"apiSharingNgLinkSharePermission",
"apiSharingNgLinkShareRoot",
"apiSharingNgPermissions",
"apiSharingNgRoot",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But doing this, won't it make a little bit difficult to distinguish for link share test scenarios? Like: using the suites name apiSharingNgLinkSharePermission makes it more clear that it is related to link share. 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests are only link share then it's good 👍

],
"skip": False,
},
Expand Down
30 changes: 26 additions & 4 deletions tests/acceptance/config/behat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,20 @@ default:
- PublicWebDavContext:
- SharingNgContext:

apiSharingNg:
apiSharingNg1:
paths:
- "%paths.base%/../features/apiSharingNg"
- "%paths.base%/../features/apiSharingNg1"
context: *common_ldap_suite_context
contexts:
- FeatureContext: *common_feature_context_params
- SpacesContext:
- SharingNgContext:
- OcisConfigContext:
- SettingsContext:

apiSharingNg2:
paths:
- "%paths.base%/../features/apiSharingNg2"
context: *common_ldap_suite_context
contexts:
- FeatureContext: *common_feature_context_params
Expand All @@ -347,9 +358,20 @@ default:
- SpacesContext:
- SharingNgContext:

apiSharingNgLinkShare:
apiSharingNgLinkSharePermission:
paths:
- "%paths.base%/../features/apiSharingNgLinkSharePermission"
context: *common_ldap_suite_context
contexts:
- FeatureContext: *common_feature_context_params
- SpacesContext:
- SharingNgContext:
- PublicWebDavContext:
- OcisConfigContext:

apiSharingNgLinkShareRoot:
paths:
- "%paths.base%/../features/apiSharingNgLinkShare"
- "%paths.base%/../features/apiSharingNgLinkShareRoot"
context: *common_ldap_suite_context
contexts:
- FeatureContext: *common_feature_context_params
Expand Down
100 changes: 50 additions & 50 deletions tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md
View file
Open in desktop

Large diffs are not rendered by default.

0 ...iSharingNg/enableDisableShareSync.feature → ...SharingNg1/enableDisableShareSync.feature
View file
Open in desktop
File renamed without changes.
0 ...ures/apiSharingNg/listPermissions.feature → ...res/apiSharingNg1/listPermissions.feature
View file
Open in desktop
File renamed without changes.
0 ...tures/apiSharingNg/propfindShares.feature → ...ures/apiSharingNg1/propfindShares.feature
View file
Open in desktop
File renamed without changes.
0 .../apiSharingNg/removeAccessToDrive.feature → ...apiSharingNg1/removeAccessToDrive.feature
View file
Open in desktop
File renamed without changes.
74 changes: 1 addition & 73 deletions ...SharingNg/removeAccessToDriveItem.feature → ...haringNg1/removeAccessToDriveItem.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,78 +107,6 @@ Feature: Remove access to a drive item
| Uploader | FolderToShare |


Scenario Outline: user removes access to a folder in link share
Given user "Alice" has created folder "FolderToShare"
And user "Alice" has created the following resource link share:
| resource | FolderToShare |
| space | Personal |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of folder "FolderToShare" from space "Personal" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| upload |
| createOnly |
| blocksDownload |


Scenario Outline: user removes access to a file in link share
Given user "Alice" has uploaded file "filesForUpload/textfile.txt" to "textfile.txt"
And user "Alice" has created the following resource link share:
| resource | textfile.txt |
| space | Personal |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of file "textfile.txt" from space "Personal" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| blocksDownload |


Scenario Outline: user removes access to a folder in project space in link share
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "NewSpace" with the default quota using the Graph API
And user "Alice" has created a folder "FolderToShare" in space "NewSpace"
And user "Alice" has created the following resource link share:
| resource | FolderToShare |
| space | NewSpace |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of folder "FolderToShare" from space "NewSpace" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| upload |
| createOnly |
| blocksDownload |


Scenario Outline: user removes access to a file in project space in link share
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "NewSpace" with the default quota using the Graph API
And user "Alice" has uploaded a file inside space "NewSpace" with content "some content" to "textfile.txt"
And user "Alice" has created the following resource link share:
| resource | textfile.txt |
| space | NewSpace |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of file "textfile.txt" from space "NewSpace" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| blocksDownload |


Scenario Outline: user removes user member from project space using permissions endpoint
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "NewSpace" with the default quota using the Graph API
Expand Down Expand Up @@ -214,4 +142,4 @@ Feature: Remove access to a drive item
| permissions-role |
| Space Viewer |
| Space Editor |
| Manager |
| Manager |
0 .../features/apiSharingNg/sharedByMe.feature → ...features/apiSharingNg1/sharedByMe.feature
View file
Open in desktop
File renamed without changes.
0 ...eatures/apiSharingNg/sharedWithMe.feature → ...atures/apiSharingNg1/sharedWithMe.feature
View file
Open in desktop
File renamed without changes.
0 ...haringNg/sharedWithMeSyncDisabled.feature → ...aringNg1/sharedWithMeSyncDisabled.feature
View file
Open in desktop
File renamed without changes.
81 changes: 81 additions & 0 deletions tests/acceptance/features/apiSharingNg2/removeAccessToDriveItemInLinkShare.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
Feature: Remove access to a drive item
https://owncloud.dev/libre-graph-api/#/drives.permissions/DeletePermission

Background:
Given these users have been created with default attributes and without skeleton files:
| username |
| Alice |
| Brian |
And using spaces DAV path


Scenario Outline: user removes access to a folder in link share
Given user "Alice" has created folder "FolderToShare"
And user "Alice" has created the following resource link share:
| resource | FolderToShare |
| space | Personal |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of folder "FolderToShare" from space "Personal" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| upload |
| createOnly |
| blocksDownload |


Scenario Outline: user removes access to a file in link share
Given user "Alice" has uploaded file "filesForUpload/textfile.txt" to "textfile.txt"
And user "Alice" has created the following resource link share:
| resource | textfile.txt |
| space | Personal |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of file "textfile.txt" from space "Personal" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| blocksDownload |


Scenario Outline: user removes access to a folder in project space in link share
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "NewSpace" with the default quota using the Graph API
And user "Alice" has created a folder "FolderToShare" in space "NewSpace"
And user "Alice" has created the following resource link share:
| resource | FolderToShare |
| space | NewSpace |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of folder "FolderToShare" from space "NewSpace" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| upload |
| createOnly |
| blocksDownload |


Scenario Outline: user removes access to a file in project space in link share
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "NewSpace" with the default quota using the Graph API
And user "Alice" has uploaded a file inside space "NewSpace" with content "some content" to "textfile.txt"
And user "Alice" has created the following resource link share:
| resource | textfile.txt |
| space | NewSpace |
| permissionsRole | <permissions-role> |
| password | %public% |
When user "Alice" removes the link of file "textfile.txt" from space "NewSpace" using the Graph API
Then the HTTP status code should be "204"
Examples:
| permissions-role |
| view |
| edit |
| blocksDownload |
Loading