Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added e2e test to delete multiple resources from trashbin #10449

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[tests-only][full-ci] added e2e test to delete multiple resources from trashbin #10449

merged 1 commit into from
Feb 9, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Feb 7, 2024 •
edited
Loading

Description

In this PR,

  • Added e2e test to delete multiple resources at once from trashbin
  • Removed scenarios related to trashbin delete from web UI tests

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@PrajwolAmatya PrajwolAmatya self-assigned this Feb 7, 2024
@PrajwolAmatya PrajwolAmatya changed the title [tests-only]delete multiple resources from trashbin [tests-only][full-ci] added e2e test to delete multiple resources from trashbin Feb 8, 2024
@PrajwolAmatya PrajwolAmatya force-pushed the tests/e2e-trashbin-delete branch 2 times, most recently from 313e30d to 0c150a6 Compare February 8, 2024 04:15
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review February 8, 2024 04:17
This was referenced Feb 8, 2024
Closed
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PrajwolAmatya PrajwolAmatya merged commit bd5fac1 into master Feb 9, 2024
3 checks passed
@PrajwolAmatya PrajwolAmatya deleted the tests/e2e-trashbin-delete branch February 9, 2024 05:46
@S-Panta S-Panta mentioned this pull request Feb 27, 2024
Closed
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@PrajwolAmatya @saw-jan
delete multiple resources from trashbin (#10449)
bf0c1f7
@saw-jan saw-jan mentioned this pull request Mar 5, 2024
Merged
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@PrajwolAmatya @saw-jan
delete multiple resources from trashbin (#10449)
e633e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrajwolAmatya @saw-jan