Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] rewriting tests. share with custom permissions #10499

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

ScharfViktor
Copy link
Contributor

part of #10259

  • checked and deleted UI test on accept decline share
  • rewrite tests: sharing to multiple user with custom permissions
  • rewrite tests: sharing to multiple groups with custom permissions

Copy link

update-docs bot commented Feb 20, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@@ -27,4 +27,4 @@ Other free text and markdown formatting can be used elsewhere in the document if

### [PROPFIND to sub-folder of a shared resources with same name gives 404](https://github.com/owncloud/ocis/issues/3859)

- [webUISharingAcceptShares/acceptShares.feature:73](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L73)
- [webUISharingAcceptShares/acceptShares.feature:16](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L16)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will be rewritten and deleted here: #10488

Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScharfViktor ScharfViktor merged commit 85fb963 into master Feb 21, 2024
3 checks passed
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@ScharfViktor ScharfViktor deleted the shareWithCustomPerm branch July 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants