-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] add batch restore e2e test and remove acceptance counterparts #10890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
Quality Gate passedIssues Measures |
saw-jan
requested review from
grgprarup,
Salipa-Gurung,
S-Panta,
PrajwolAmatya and
ScharfViktor
May 10, 2024 09:16
PrajwolAmatya
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ScharfViktor
approved these changes
May 13, 2024
saw-jan
commented
May 14, 2024
) | ||
} | ||
|
||
await Promise.all([waitResponses, page.locator(restoreResourceButton).click()]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUST spread the array
await Promise.all([...waitResponses, page.locator(restoreResourceButton).click()])
saw-jan
added a commit
that referenced
this pull request
May 14, 2024
7 tasks
saw-jan
added a commit
that referenced
this pull request
May 15, 2024
anon-pradip
pushed a commit
to anon-pradip/web
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added batch retore e2e test and removed the acceptance counterparts.
Some test-cases covered in API: owncloud/ocis#9126
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes