[full-ci] remove old acceptance tests #10921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ScharfViktor
force-pushed
the
removeAcceptanceTest
branch
from
7aad9a6
to
4274b1b
Compare
|
ScharfViktor
commented
May 16, 2024
Comment on lines
-38
to
-39
| We're slowly moving away from the nightwatch.js-based e2e tests. As our coverage with playwright based e2e tests grows continuously, it might | ||
| happen that you will not find the `/tests/acceptance` folder anymore. If that's the case at the time of reading this, those are happy times. |
There was a problem hiding this comment.
@kulmann I'm really glad that I'm reading this. now we can say it's a happy time ❤️
kulmann
approved these changes
May 16, 2024
ownclouders
pushed a commit
that referenced
this pull request
May 16, 2024
7 tasks
18 tasks
ScharfViktor
added a commit
that referenced
this pull request
May 17, 2024
Merged
AlexAndBear
added a commit
that referenced
this pull request
May 18, 2024
* remove old acceptance tests (#10921) --------- Co-authored-by: Jan Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #10259