Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix few serialization issues #2506

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix few serialization issues #2506

merged 1 commit into from
Feb 26, 2024

Conversation

ArnaudBarre
Copy link
Contributor

Re: #2463

@github-actions github-actions bot added the A-ast Area - AST label Feb 26, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 26, 2024

CodSpeed Performance Report

Merging #2506 will not alter performance

Comparing ArnaudBarre:arrow-functions-span (5f63e6f) with main (70295a5)

Summary

✅ 27 untouched benchmarks

@Boshen Boshen merged commit b8764a8 into oxc-project:main Feb 26, 2024
17 checks passed
@ArnaudBarre ArnaudBarre deleted the arrow-functions-span branch February 26, 2024 08:31
@ArnaudBarre ArnaudBarre mentioned this pull request Feb 27, 2024
Merged
Boshen pushed a commit that referenced this pull request Feb 27, 2024
@ArnaudBarre
fix(ast): few serialization issues (#2522)
6d5ec6d 
A few more I missed in #2506. Re #2463.

Only remaining snake_case in the current types of the AST:
`trailing_comma` in ArrayExpression, ObjectExpression &
ArrayAssignmentTarget.
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@ArnaudBarre @IWANABETHATGUY
Fix few serialization issues (oxc-project#2506)
9ad8f89 
Re: oxc-project#2463
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@ArnaudBarre @IWANABETHATGUY
fix(ast): few serialization issues (oxc-project#2522)
995732f 
A few more I missed in oxc-project#2506. Re oxc-project#2463.

Only remaining snake_case in the current types of the AST:
`trailing_comma` in ArrayExpression, ObjectExpression &
ArrayAssignmentTarget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-ast Area - AST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnaudBarre @Boshen