Fix how errors are handled when submitting a test to TF #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lachmanfrantisek
approved these changes
Apr 15, 2021
This comment has been minimized.
This comment has been minimized.
When a TF refuses a new test request, it sends back
reason: 'Bad Request'
errors: (e.g.) {'environments': {'0': {'arch': "must be one of: 'x86_64'"}}}
While the reason is nicer, it doesn't contain any info
so users would need to wait for us to tell them what
actually happened.
So far we've hit only the unsupported arch error,
so let's extract it from the error json.
adrianreber/criu#6 (comment)
jpopelka
force-pushed
the
tft-submit-error
branch
from
40f57e8
to
37ea294
Compare
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
jpopelka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message is in 'errors', not 'message'.
When a TF refuses a new test request, it sends back
While the reason is nicer, it doesn't contain any info so users would need to wait for us to tell them what actually happened.
So far we've hit only the unsupported arch error, so let's extract it from the error json.
adrianreber/criu#6 (comment)