Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how errors are handled when submitting a test to TF #1055

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Fix how errors are handled when submitting a test to TF #1055

merged 2 commits into from
Apr 15, 2021

Commits on Apr 15, 2021

  1. Error message is in 'errors', not 'message' 

    When a TF refuses a new test request, it sends back
reason: 'Bad Request'
errors: (e.g.) {'environments': {'0': {'arch': "must be one of: 'x86_64'"}}}

While the reason is nicer, it doesn't contain any info
so users would need to wait for us to tell them what
actually happened.

So far we've hit only the unsupported arch error,
so let's extract it from the error json.

adrianreber/criu#6 (comment)
    @jpopelka
    jpopelka committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    9168e1d View commit details
    Browse the repository at this point in the history

  2. Use 'run --pull=always' instead of separately pulling image

    @jpopelka
    jpopelka committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    37ea294 View commit details
    Browse the repository at this point in the history