Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-896]: Sign up page #345

Merged
merged 23 commits into from
Nov 13, 2023
Merged

[DEV-896]: Sign up page #345

merged 23 commits into from
Nov 13, 2023

Conversation

MikeAtUqido
Copy link
Collaborator

List of Changes

  • Added Sign Up page

Motivation and Context

The user needs a page to sign up to the developer portal

How Has This Been Tested?

  • Manually
  • Partially by unit tests

Screenshots (if appropriate):

PagoPA-DevPortal - Sign Up 1

PagoPA-DevPortal - Sign Up 2

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MikeAtUqido MikeAtUqido self-assigned this Oct 23, 2023
@MikeAtUqido MikeAtUqido marked this pull request as ready for review October 23, 2023 15:04
@kin0992 kin0992 changed the base branch from main to add-hompage-to-strapi October 26, 2023 14:33
@kin0992 kin0992 changed the base branch from add-hompage-to-strapi to main October 26, 2023 14:33
@kin0992 kin0992 force-pushed the feature/DEV-896-sign-up branch from 22ce8ee to 01134ae Compare October 27, 2023 12:54
@kin0992
Copy link
Contributor

kin0992 commented Oct 30, 2023

The "Reinvia e-mail" doesn't match the figma design.
Screenshot 2023-10-30 at 16 41 23

apps/nextjs-website/src/lib/types/signUpFunction.ts Outdated Show resolved Hide resolved
apps/nextjs-website/src/app/auth/sign-up/page.tsx Outdated Show resolved Hide resolved
apps/nextjs-website/src/app/auth/sign-up/page.tsx Outdated Show resolved Hide resolved
@MikeAtUqido MikeAtUqido requested a review from kin0992 November 8, 2023 13:42
@MikeAtUqido MikeAtUqido requested a review from datalek November 8, 2023 16:39
/>
)}
{signUpStep === SignUpSteps.CONFIRM_SIGN_UP && (
<ConfirmSignUp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I'm on the confirmation page, if I refresh the page and click the "Reinvia e-mail" link I get an error

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug with the email aliases (those with a + sign), it doesn't happen with regular emails, should we correct for those email or we want to let users set up multiple accounts with the same email even in production?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeAtUqido IMHO it should be fixed. I think the best option, at the moment, is to create an activity explaining the problem and then add the link of the activity here.
can you do it, please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the activity: DEV-1114

@MikeAtUqido MikeAtUqido requested a review from datalek November 9, 2023 15:58
Copy link
Contributor

Branch is not up to date with base branch

@MikeAtUqido it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-896

Copy link
Contributor

This PR exceeds the recommended size of 800 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 75.5 KB (🟡 +16 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/_error 185 B 75.68 KB 21.62% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@kin0992 kin0992 merged commit ed6d4f7 into main Nov 13, 2023
8 of 10 checks passed
@kin0992 kin0992 deleted the feature/DEV-896-sign-up branch November 13, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants