-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-896]: Sign up page #345
Conversation
22ce8ee
to
01134ae
Compare
apps/nextjs-website/src/components/organisms/Auth/ConfirmSignUp.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/organisms/Auth/ConfirmSignUp.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/molecules/CheckItem/CheckItem.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/organisms/Auth/SignUpForm.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/organisms/Auth/SignUpForm.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/molecules/RequiredTextField/RequiredTextField.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/molecules/RequiredTextField/RequiredTextField.tsx
Show resolved
Hide resolved
apps/nextjs-website/src/components/organisms/Auth/ConfirmSignUp.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/organisms/Auth/ConfirmSignUp.tsx
Outdated
Show resolved
Hide resolved
/> | ||
)} | ||
{signUpStep === SignUpSteps.CONFIRM_SIGN_UP && ( | ||
<ConfirmSignUp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I'm on the confirmation page, if I refresh the page and click the "Reinvia e-mail" link I get an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bug with the email aliases (those with a +
sign), it doesn't happen with regular emails, should we correct for those email or we want to let users set up multiple accounts with the same email even in production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeAtUqido IMHO it should be fixed. I think the best option, at the moment, is to create an activity explaining the problem and then add the link of the activity here.
can you do it, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the activity: DEV-1114
apps/nextjs-website/src/components/organisms/Auth/SignUpForm.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-website/src/components/molecules/RequiredTextField/RequiredTextField.tsx
Show resolved
Hide resolved
apps/nextjs-website/src/components/organisms/Auth/SignUpForm.tsx
Outdated
Show resolved
Hide resolved
Branch is not up to date with base branch@MikeAtUqido it seems this Pull Request is not updated with base branch. |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-896 |
This PR exceeds the recommended size of 800 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
📦 Next.js Bundle Analysis for nextjs-websiteThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
75.5 KB (🟡 +16 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/_error |
185 B |
75.68 KB | 21.62% (+/- <0.01%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
List of Changes
Motivation and Context
The user needs a page to sign up to the developer portal
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: