Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-896]: Sign up page #345
[DEV-896]: Sign up page #345
Changes from 15 commits
a4aa6e4
01134ae
886c528
b313b62
2a7d098
35fb16a
c33d539
a6c51d4
fe4f12c
3d5c9de
9063388
9093911
a0dfb3e
4605744
eb34860
9f6067f
d1daf0f
9b49c94
2a62d9c
8b401bd
2c2b9e9
43f7627
e958c53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I'm on the confirmation page, if I refresh the page and click the "Reinvia e-mail" link I get an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bug with the email aliases (those with a
+
sign), it doesn't happen with regular emails, should we correct for those email or we want to let users set up multiple accounts with the same email even in production?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeAtUqido IMHO it should be fixed. I think the best option, at the moment, is to create an activity explaining the problem and then add the link of the activity here.
can you do it, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the activity: DEV-1114