-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOPLT-703] Add reference to APIM key and add new variables #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kin0992
changed the title
[IOPLT-699] Add reference to APIM key and add new variables
[IOPLT-703] Add reference to APIM key and add new variables
Sep 20, 2024
The new variables have been introduced to migrate backend traffic from the Azure functions to the APIM, allowing to do that with no downtime
kin0992
force-pushed
the
features/add-trial-system-apim-key
branch
from
September 23, 2024 07:17
0e82373
to
0945bc3
Compare
AleDore
approved these changes
Sep 24, 2024
Quality Gate passedIssues Measures |
AleDore
approved these changes
Sep 24, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new variables have been introduced to migrate backend traffic from the Azure functions to the APIM, allowing to do that with no downtime
List of changes
TRIAL_SYSTEM_APIM_URL
env variable containing the Trial System APIM base URLTRIAL_SYSTEM_APIM_KEY
env variable containing the API key the backend will use to authenticateTRIAL_SYSTEM_APIM_BASE_PATH
env variableapp_backend_TRIAL_SYSTEM_APIM_KEY
key vault secretMotivation and context
The traffic of the backend will be moved from the Trial System's Azure function to the APIM.
Note
The legacy environment variables are still there to guarantee no downtime.
When the traffic is totally migrated, we can proceed to new PRs to remove old env variables.
Type of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)
How to apply
After PR is approved