Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-703] Add reference to APIM key and add new variables #1176

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

kin0992
Copy link
Contributor

@kin0992 kin0992 commented Sep 19, 2024

The new variables have been introduced to migrate backend traffic from the Azure functions to the APIM, allowing to do that with no downtime

List of changes

  • Add TRIAL_SYSTEM_APIM_URL env variable containing the Trial System APIM base URL
  • Add TRIAL_SYSTEM_APIM_KEY env variable containing the API key the backend will use to authenticate
  • Add TRIAL_SYSTEM_APIM_BASE_PATH env variable
  • Add reference to app_backend_TRIAL_SYSTEM_APIM_KEY key vault secret

Motivation and context

The traffic of the backend will be moved from the Trial System's Azure function to the APIM.

Note

The legacy environment variables are still there to guarantee no downtime.
When the traffic is totally migrated, we can proceed to new PRs to remove old env variables.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

The new variables have been introduced to migrate backend traffic from the Azure functions to the APIM, allowing to do that with no downtime
Copy link

sonarcloud bot commented Sep 24, 2024

@AleDore AleDore merged commit 39504dd into main Sep 24, 2024
7 of 12 checks passed
@AleDore AleDore deleted the features/add-trial-system-apim-key branch September 24, 2024 07:57
@kin0992 kin0992 mentioned this pull request Sep 25, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants