Merge pull request #195 from consideRatio/conda-env-filter

Let base-image recognize jupyter_notebook_config.py, and configure nb_conda_kernels to not register a kernel again

base-image/Dockerfile

@@ -59,7 +59,8 @@ ENTRYPOINT ["/srv/start"]
 # Only run these if used as a base image
 # ----------------------
 ONBUILD USER root
-# hardcode for now
+# FIXME (?): user and home folder is hardcoded for now
+# FIXME (?): this line breaks the cache of all steps below
 ONBUILD COPY --chown=jovyan:jovyan . /home/jovyan
 
 ONBUILD RUN echo "Checking for 'binder' or '.binder' subfolder" \
@@ -82,6 +83,15 @@ ONBUILD RUN echo "Checking for 'apt.txt'..." \
         && rm -rf /var/lib/apt/lists/* \
         ; fi
 
+# Copy jupyter_notebook_config.py to /etc/jupyter
+ONBUILD RUN echo "Checking for 'jupyter_notebook_config.py'..." \
+        ; [ -d binder ] && cd binder \
+        ; [ -d .binder ] && cd .binder \
+        ; if test -f "jupyter_notebook_config.py" ; then \
+        mkdir -p /etc/jupyter \
+        && cp jupyter_notebook_config.py /etc/jupyter \
+        ; fi
+
 ONBUILD USER ${NB_USER}
 
 # Create "notebook" conda environment and dask labextensions

ml-notebook/jupyter_notebook_config.py

@@ -0,0 +1,5 @@
+import os
+
+# Configure nb_conda_kernels to avoid registering jupyter kernels in our conda
+# environment again.
+c.CondaKernelSpecManager.env_filter = f'.*envs/{os.environ["CONDA_ENV"]}.*'

pangeo-notebook/jupyter_notebook_config.py

@@ -0,0 +1,5 @@
+import os
+
+# Configure nb_conda_kernels to avoid registering jupyter kernels in our conda
+# environment again.
+c.CondaKernelSpecManager.env_filter = f'.*envs/{os.environ["CONDA_ENV"]}.*'