Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Flink #150

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Upgrade Flink #150

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87634ae
addresses #149 upgrade
Nov 21, 2023
368f956
2.50
Nov 21, 2023
e2e95ec
do not deprecate
Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/flink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ jobs:
matrix:
python-version: [ "3.9", "3.10", "3.11" ]
recipes-version: [
"pangeo-forge-recipes==0.9.4",
"pangeo-forge-recipes==0.10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranchodeluxe generally I like deprecating 0.9.4 support (#144) but for my understanding, is there a reason this is part of this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thanks for the lightening-fast turnaround on this!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, haha, we can change it back so you can do the deprecation sorry (just thought I'd add it in)

# save some cycles and infer it might
# work on all versions between lowest and highest
# "pangeo-forge-recipes==0.10.0",
# "pangeo-forge-recipes==0.10.3",
"pangeo-forge-recipes==0.10.4",
]
Expand All @@ -46,7 +45,12 @@ jobs:
"apache-beam==2.51.0",
]
# keep here to be explicit for future users what version
# of Flink we are supporting
# of Flink we are supporting.
#
# Even though the operator says it's running Flink 1.17
# there is no portable runner .jar available yet :scream: :thanksflink:
# https://repo.maven.apache.org/maven2/org/apache/beam/beam-runners-flink*
# but things seem stable for 1.16 :fingerscrossed:
flink-version: [ "1.16", ]

steps:
Expand Down Expand Up @@ -81,7 +85,10 @@ jobs:

- name: Setup FlinkOperator
run: |
FLINK_OPERATOR_VERSION=1.5.0
# as noted here: https://github.com/pangeo-forge/pangeo-forge-cloud-federation/pull/6#issuecomment-1821285529
# and more specifically here: https://cwiki.apache.org/confluence/display/FLINK/Release+Schedule+and+Planning
# "Support for two (current and previous) releases with bug fixes"
FLINK_OPERATOR_VERSION=1.6.1
helm repo add flink-operator-repo https://downloads.apache.org/flink/flink-kubernetes-operator-${FLINK_OPERATOR_VERSION}
helm install flink-kubernetes-operator flink-operator-repo/flink-kubernetes-operator --wait

Expand Down
Loading