Fix serde test features #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Brown <[email protected]>
Superhepper
previously approved these changes
Aug 6, 2024
Superhepper
reviewed
Aug 7, 2024
There was a problem hiding this comment.
I wonder if it would be possible to achieve this using Resolver = 2 instead in the cargo.toml?
Something like this:
[package]
name = "B"
resolver = "2"[features]
serde = []
abstractions = []
integration-tests = [][dev-dependencies]
B = { path = ".", features = ["test-utils", "abstractions", "integration-tests"] }
I am not sure this is a good idea or not. But I think it is worth trying. Because I think it is a good idea to build all the tests as standard and if you want to be clever you can add some command line arguments.
Superhepper
approved these changes
Aug 17, 2024
|
I will try to work on the Cargo configuration things in another PR. |
Superhepper
added a commit
to Superhepper/rust-tss-esapi
that referenced
this pull request
Aug 30, 2024
This PR builds upon the work made in parallaxsecond#539 and parallaxsecond#538 and fixes a problem with running tests required several features to be specified in order for the tests to compile. This has been accomplish by doing the following: 1. Tests have been refactored in order to avoid dependency on features that may and may not be available. 2. Updated workspace Cargo.toml to use version 2 resolver. 3. Updated tss-esapi Cargo.toml to use the crate it self as dev-dependency with most of the features enabled. Co-authored-by: Travis Finkenauer <[email protected]> Co-authored-by: William Brown <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
added a commit
to Superhepper/rust-tss-esapi
that referenced
this pull request
Aug 30, 2024
This PR builds upon the work made in parallaxsecond#539 and parallaxsecond#538 and fixes a problem with running tests required several features to be specified in order for the tests to compile. This has been accomplish by doing the following: 1. Tests have been refactored in order to avoid dependency on features that may and may not be available. 2. Updated workspace Cargo.toml to use version 2 resolver. 3. Updated tss-esapi Cargo.toml to use the crate it self as dev-dependency with most of the features enabled. Co-authored-by: Travis Finkenauer <[email protected]> Co-authored-by: William Brown <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.