-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Bundles Property for Manual Bundles, loadedBy #9294
Open
AGawrys
wants to merge
14
commits into
v2
Choose a base branch
from
agawrys/active-manual-bundles-prop
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
AGawrys
force-pushed
the
agawrys/active-manual-bundles-prop
branch
from
December 13, 2023 00:40
6af43da
to
dda9263
Compare
AGawrys
changed the title
Active Source Bundles Property for Manual Bundles
Source Bundles Property for Manual Bundles, loadedBy
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR adds more configuration to the
unstable_manualSharedBundle
feature for the bundle. Users can now specify an array of"loadedBy"
Bundles for a manualSharedBundle. TheloadedBy
property is essentiallybundle.sourceBundles
within the bundler.This allows assets that would otherwise match an MSB glob, to instead be duplicated or inserted into traditional shared bundles if needed. This is useful in the case that a later loading bundle requires an MSB. This way we can ensure the manual bundle is not loaded earlier by some other bundle requiring an asset it contains.
This pr also renames the optional "parent" config option to "root".
💻 Usage
Specify an array of BundleRoots (i.e. code split point or entries) via filePath relative to the project root, which will then use the manualSharedBundle, duplicating the assets for any other bundles which require those assets.
In the below example, only
activeSource1.js
andactiveSource2.js
(which are bundles) will use thevendor
manualSharedBundle. Any other bundles that requirevendor
assets will get them from either a traditional shared bundle or via duplication.✔️ PR Todo