Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-verify-signature to umbrella crate #6515

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Migrate pallet-verify-signature to umbrella crate #6515

wants to merge 15 commits into from
+57 −83

Conversation

bennethxyz
Copy link

@bennethxyz bennethxyz commented Nov 18, 2024 •
edited
Loading

Part of #6504

Review Notes

  • Adding UintAuthorityId from sp_runtime::testing module to frame::runtime::testing_prelude.

polkadot address: 15rM9idTv1izwNFqPabfcT4jkqHDsEvHSa5fASAUZwZcS4Yw

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 18, 2024

User @bennethxyz, please sign the CLA here.

@bennethxyz bennethxyz marked this pull request as ready for review November 24, 2024 22:18
@bennethxyz bennethxyz requested a review from a team as a code owner November 24, 2024 22:18
@bennethxyz bennethxyz mentioned this pull request Dec 2, 2024
Open
91 tasks
@bennethxyz
Copy link
Author

@re-gius @kianenigma Ready for review 🙏

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Dec 9, 2024
@bennethxyz
Copy link
Author

please review @re-gius

re-gius
re-gius approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review failing CIs + be careful when merging new changes to the umbrella crate

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Review required! Latest push from author must always be reviewed

@github-actions github-actions bot requested a review from re-gius January 4, 2025 02:28
@bennethxyz
Copy link
Author

Please review @re-gius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennethxyz @re-gius