-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tracking] Migrate pallets to umbrella crate #6504
Comments
Can I pick this up @re-gius Thinking this should be a tracking issue as it involves more than one crate but happy to do it! |
Yes, it's going to be a tracking issue. You are more than welcome to start working at some pallets/crates, ideally one or two per PR. |
Are there still some pallets to work on or are you doing all of them? |
Taking pallet-paged-list and pallet-paged-list-fuzzer since they go together |
Hi, I'd like to work on this. I will pickup |
Part of #6504 --------- Co-authored-by: Giuseppe Re <[email protected]>
Hi, I'd like to work on this. I will pickup |
Pick |
taking |
taking |
taking |
Just a quick note from my recent changes if it helps anyone save time because running Overall I think it best to add systems in the prelude as there are needed in the particular pallet one is migrating and also if there exists in more than one pallet. For example I considered adding |
Due to the same reason. I didnot add |
Which one of them? @AurevoirXavier |
As in #6202 , we will reward each contributor with a small tip (20 DOT) once every two pallets (or one big pallet). |
Why are we migrating to the |
I think that we will remove the experimental feature flag after a few merged PRs like this, when the umbrella crate will be more stable. What do you think @kianenigma ? |
For those of you that have open PRs, please notice that as we start merging PRs that add items to the umbrella crate preludes, you need to be careful with merging your changes since there may be overlaps. |
taking |
Part of paritytech#6504 --------- Co-authored-by: Giuseppe Re <[email protected]>
Opened an issue to convert the devensive! macro to be compatible with umbrella crate here #7054 |
this issue is ready to be merged, should be usefull for all pallets using the defensive! macro to get rid of the frame_support dep |
) # Description Migrate pallet-node-authorization to use umbrella crate. Part of paritytech#6504 ## Review Notes * This PR migrates pallet-node-authorization to use the umbrella crate. * Some imports like below have not been added to any prelude as they have very limited usage across the various pallets. ```rust use sp_core::OpaquePeerId as PeerId; ``` * Added a commonly used runtime trait for testing in the `testing_prelude` in `substrate/frame/src/lib.rs`: ```rust pub use sp_runtime::traits::BadOrigin; ``` * `weights.rs` uses the `weights_prelude` like: ```rust use frame::weights_prelude::*; ``` * `tests.rs` and `mock.rs` use the `testing_prelude`: ```rust use frame::testing_prelude::*; ``` * `lib.rs` uses the main `prelude` like: ```rust use frame::prelude::*; ``` * For testing: Checked that local build works and tests run successfully.
Migrate all pallets to
polkadot-sdk-frame
by adding types and preludes to it when necessary. As a reference, you can look into #5995.The guidelines of the umbrella crate are as follows:
polkadot-sdk/substrate/frame/src/lib.rs
Lines 134 to 150 in 06a68be
✅ Checklist:
polkadot-sdk-frame
to theCargo.toml
frame_support
,sp_runtime
and similar, and replace with the appropriateprelude::*
deps
Cargo.toml
to remove all unneeded dependencies.👉 If you want to work on this: Please check that there is not already a merge request for the pallet that you want to work on (here or in the comments below). Please pick only one or a small set of pallets - not all at once. This keeps review times low. Add a comment below to announce the pallets you're working on.
Pallet list
pallet-alliance
to umbrella crate #6541pallet-assets-freezer
to umbrella crate #6599pallet-atomic-swap
to umbrella crate #6601pallet-aura
to umbrella crate #6622pallet-authority-discovery
to umbrella crate #6619pallet-authorship
to umbrella crate #6620pallet-babe
&pallet-staking-reward-curve
#6412pallet-im-online
to umbrella crate #6736pallet-indices
to umbrella crate #6737pallet-insecure-randomness-collective-flip
to umbrella crate #6738pallet-lottery
to umbrella crate #6740pallet-proxy
andpallet-multisig
#5995pallet-proxy
andpallet-multisig
#5995pallet-babe
&pallet-staking-reward-curve
#6412pallet-timestamp
to umbrella crate #6523pallet-tips
to umbrella crate #6532pallet-tx-pause
to umbrella crate #6630pallet-verify-signature
to umbrella crate #6515pallet-whitelist
to umbrella crate #6514The text was updated successfully, but these errors were encountered: