Migrate pallet-alliance to umbrella crate
#6541
Open
+82
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also should be ready for review @re-gius 🙏 |
91 tasks
|
please review @kianenigma @re-gius |
re-gius
added
R0-silent
re-gius
reviewed
Dec 9, 2024
| use super::{Call as AllianceCall, Pallet as Alliance, *}; | ||
| use core::{cmp, mem::size_of}; | ||
| use frame::{benchmarking::prelude::*, traits::UnfilteredDispatchable}; | ||
| use frame_system::Pallet as System; |
There was a problem hiding this comment.
As in my previous observation, please check if assert_last_event is widely used and should be added to the benchmarking prelude.
There was a problem hiding this comment.
We could leave things as
use frame::benchmarking::prelude::{*, RawOrigin as SystemOrigin, frame_system::Pallet as System};until we migrate most pallets? @re-gius @kianenigma
There was a problem hiding this comment.
assert_last_event are sometimes instantiable, creating one function for both occurrences?
please could you explain a bit more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504
Description
Modifying pallet-alliance to use umbrella crate whilst
BoundedVectoframe::runtime::prelude, which I think should be necessary for mock runtimes in more than one pallet.testing_prelude. This exports all relevant types used in event checking among various mock runtimes.