Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-insecure-randomness-collective-flip to umbrella crate #6738

Merged
merged 12 commits into from
Jan 22, 2025
Merged

Migrate pallet-insecure-randomness-collective-flip to umbrella crate #6738

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
05e458b
import umbrella crate
FereMouSiopi Dec 3, 2024
37439a2
Merge branch 'master' into umbrella-ircf
FereMouSiopi Dec 3, 2024
d09e8b4
prelude all
FereMouSiopi Dec 12, 2024
f3dced5
Merge branch 'master' into umbrella-ircf
FereMouSiopi Dec 12, 2024
897a1d2
nit commenting 1
FereMouSiopi Dec 12, 2024
697ffdc
nit
FereMouSiopi Jan 2, 2025
849ace9
Merge branch 'master' into umbrella-ircf
FereMouSiopi Jan 2, 2025
a56280c
Update from ggwpez running command 'prdoc --audience runtime_dev --bu…
Jan 2, 2025
9b55c32
remove Randomness from prelude
FereMouSiopi Jan 4, 2025
324dfcd
Merge branch 'master' into umbrella-ircf
bkchr Jan 6, 2025
c4c019e
Merge branch 'master' into umbrella-ircf
FereMouSiopi Jan 19, 2025
7d136c3
frame/experimental<
FereMouSiopi Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 3 additions & 15 deletions substrate/frame/insecure-randomness-collective-flip/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,30 +17,18 @@ targets = ["x86_64-unknown-linux-gnu"]

[dependencies]
codec = { features = ["derive"], workspace = true }
frame-support = { workspace = true }
frame-system = { workspace = true }
safe-mix = { workspace = true }
scale-info = { features = ["derive"], workspace = true }
sp-runtime = { workspace = true }

[dev-dependencies]
sp-core = { workspace = true, default-features = true }
sp-io = { workspace = true, default-features = true }
frame = { workspace = true, features = ["experimental", "runtime"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
frame = { workspace = true, features = ["experimental", "runtime"] }
frame = { workspace = true, features = ["runtime"] }

See #7177


[features]
default = ["std"]
std = [
"codec/std",
"frame-support/std",
"frame-system/std",
"frame/std",
"safe-mix/std",
"scale-info/std",
"sp-core/std",
"sp-io/std",
"sp-runtime/std",
]
try-runtime = [
"frame-support/try-runtime",
"frame-system/try-runtime",
"sp-runtime/try-runtime",
"frame/try-runtime",
]
28 changes: 9 additions & 19 deletions substrate/frame/insecure-randomness-collective-flip/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,11 @@
//! ### Example - Get random seed for the current block
//!
//! ```
//! use frame_support::traits::Randomness;
//! use frame::{prelude::*, traits::Randomness};
//!
//! #[frame_support::pallet]
//! #[frame::pallet]
//! pub mod pallet {
//! use super::*;
//! use frame_support::pallet_prelude::*;
//! use frame_system::pallet_prelude::*;
//!
//! #[pallet::pallet]
//! pub struct Pallet<T>(_);
Expand All @@ -73,9 +71,7 @@
use safe_mix::TripletMix;

use codec::Encode;
use frame_support::{pallet_prelude::Weight, traits::Randomness};
use frame_system::pallet_prelude::BlockNumberFor;
use sp_runtime::traits::{Hash, Saturating};
use frame::{prelude::*, traits::Randomness};

const RANDOM_MATERIAL_LEN: u32 = 81;

Expand All @@ -87,10 +83,9 @@ fn block_number_to_index<T: Config>(block_number: BlockNumberFor<T>) -> usize {

pub use pallet::*;

#[frame_support::pallet]
#[frame::pallet]
pub mod pallet {
use super::*;
use frame_support::pallet_prelude::*;

#[pallet::pallet]
pub struct Pallet<T>(_);
Expand Down Expand Up @@ -167,19 +162,14 @@ impl<T: Config> Randomness<T::Hash, BlockNumberFor<T>> for Pallet<T> {
mod tests {
use super::*;
use crate as pallet_insecure_randomness_collective_flip;

use sp_core::H256;
use sp_runtime::{traits::Header as _, BuildStorage};

use frame_support::{
derive_impl, parameter_types,
traits::{OnInitialize, Randomness},
use frame::{
testing_prelude::{frame_system::limits, *},
traits::Header as _,
};
use frame_system::limits;

type Block = frame_system::mocking::MockBlock<Test>;

frame_support::construct_runtime!(
construct_runtime!(
pub enum Test
{
System: frame_system,
Expand All @@ -199,7 +189,7 @@ mod tests {

impl pallet_insecure_randomness_collective_flip::Config for Test {}

fn new_test_ext() -> sp_io::TestExternalities {
fn new_test_ext() -> TestExternalities {
let t = frame_system::GenesisConfig::<Test>::default().build_storage().unwrap();
t.into()
}
Expand Down
Loading