Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-insecure-randomness-collective-flip to umbrella crate #6738

Merged
merged 12 commits into from
Jan 22, 2025

Conversation

FereMouSiopi
Copy link
Contributor

Part of #6504

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Dec 3, 2024

User @FereMouSiopi, please sign the CLA here.

@FereMouSiopi FereMouSiopi marked this pull request as ready for review December 12, 2024 21:56
@FereMouSiopi FereMouSiopi requested a review from a team as a code owner December 12, 2024 21:56
@ggwpez
Copy link
Member

ggwpez commented Jan 2, 2025

/cmd prdoc --audience runtime_dev --bump minor

@FereMouSiopi
Copy link
Contributor Author

please review @re-gius

substrate/frame/src/lib.rs Outdated Show resolved Hide resolved
@bkchr bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jan 2, 2025
@github-actions github-actions bot requested a review from ggwpez January 4, 2025 20:03
Copy link

github-actions bot commented Jan 4, 2025

Review required! Latest push from author must always be reviewed

@FereMouSiopi
Copy link
Contributor Author

please review @bkchr

@bkchr bkchr enabled auto-merge January 4, 2025 20:39
@FereMouSiopi
Copy link
Contributor Author

We need the silent tag based on this comment

@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jan 6, 2025
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the experimental feature flag and then you can merge

[dev-dependencies]
sp-core = { workspace = true, default-features = true }
sp-io = { workspace = true, default-features = true }
frame = { workspace = true, features = ["experimental", "runtime"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
frame = { workspace = true, features = ["experimental", "runtime"] }
frame = { workspace = true, features = ["runtime"] }

See #7177

@github-actions github-actions bot requested review from bkchr and re-gius January 19, 2025 05:01
auto-merge was automatically disabled January 19, 2025 05:10

Head branch was pushed to by a user without write access

@re-gius re-gius enabled auto-merge January 22, 2025 16:54
@re-gius re-gius added this pull request to the merge queue Jan 22, 2025
Merged via the queue into paritytech:master with commit 89b0228 Jan 22, 2025
188 of 205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants