-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pallet-paged-list to umbrella crate #6931
base: master
Are you sure you want to change the base?
Migrate pallet-paged-list to umbrella crate #6931
Conversation
had to add frame support for defensive trait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first steps, thank you!
Please see my comments + you have compilation errors/warnings, so the CI is not passing yet.
@ggwpez Hi Oliver ! Would you know if this line can be safely removed ? idk if it has any side effects on tests but it doesnt seem to do at first glance https://github.com/paritytech/polkadot-sdk/blame/master/substrate/frame/paged-list/src/paged_list.rs#L448 |
Cannot be removed, see its drop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good minus the one comment 😄
…/github.com/Krayt78/polkadot-sdk into Migrate-pallet-paged-list-to-umbrella-crate
I added all traits that were not used by multiple pallets to the umbrella crate and integrated the defensive! macro changes following the merge of #7069 |
Part of #6504