Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - JumpLinks - scroll position & scrollspy #10860

Closed
2 tasks
evwilkin opened this issue Aug 14, 2024 · 2 comments · Fixed by #10866
Closed
2 tasks

Bug - JumpLinks - scroll position & scrollspy #10860

evwilkin opened this issue Aug 14, 2024 · 2 comments · Fixed by #10866
Assignees

Comments

@evwilkin
Copy link
Member

evwilkin commented Aug 14, 2024

Bugs identified in JumpLinks include where a clicked link is scrolled to on the screen and the scrollspy behavior not working.

JumpLinks bugs

Preview Give feedback
Screen.Recording.2024-08-14.mov
@evwilkin evwilkin added the bug label Aug 14, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 14, 2024
@kmcfaul kmcfaul moved this from Needs triage to Not started in PatternFly Issues Aug 14, 2024
@evwilkin
Copy link
Member Author

evwilkin commented Aug 14, 2024

Scrollspy:

  • feat(Page,Drawer): core bump and updates #10211 added a wrapper container .pf-v6-c-page__main-container around the main element - the demo needs to pass this as the scrollableSelector rather than the main element which gets passed the id #scrollable-element from the DashboardWrapper's mainContainerId="scrollable-element"

Scroll position:

  • Offset needs to be calculated from above wrapper element's top position (currently set to 10, should be more like 84).

@evwilkin
Copy link
Member Author

Closed by #10866

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant