Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix jumplinks scrollspy subsections demo #10866

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

evwilkin
Copy link
Member

@evwilkin evwilkin commented Aug 16, 2024

Closes #10860

This PR updates the react JumpLinks demo to update the scrollableSelector element and adjust the scroll spy function in the demo.

Note:

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 16, 2024

@kmcfaul kmcfaul linked an issue Aug 27, 2024 that may be closed by this pull request
@evwilkin evwilkin changed the title fix(docs): fix jumplinks demo fix(docs): fix jumplinks scrollspy subsections demo Aug 27, 2024
@evwilkin evwilkin requested a review from a team August 27, 2024 19:30
@andrew-ronaldson andrew-ronaldson self-requested a review August 27, 2024 19:35
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@evwilkin evwilkin merged commit 137ef68 into patternfly:v6 Aug 28, 2024
13 checks passed
@evwilkin evwilkin deleted the chore/10860-jumplinks-demo branch August 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - JumpLinks - scroll position & scrollspy
4 participants