Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade and align @dnd-kit/ dependencies #10590

Closed
wants to merge 1 commit into from

Conversation

jonkoops
Copy link
Contributor

Upgrades the @dnd-kit/ dependencies to their latest versions. This also adds the missing @dnd-kit/utilities dependency and removes the unused @dnd-kit/modifiers dependency.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 11, 2024

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to break the styles in the drag drop demos which use them
https://patternfly-react-pr-10590.surge.sh/components/drag-and-drop/react-next-demos

This is what is used to look like:
Screenshot 2024-06-11 at 8 42 04 AM

This is what it looks link in this PR:
Screenshot 2024-06-11 at 8 41 41 AM

@jonkoops
Copy link
Contributor Author

@nicolethoen looks like this might have to be reworked before it can be upgrade then. I don't have time to work on this specific area, is there someone on the team that might be able to take this over? Perhaps this is something breaking that should come along in v6?

@nicolethoen
Copy link
Contributor

nicolethoen commented Jun 11, 2024

yeah I agree. Do you want to close this and open an issue instead? you could even reference this PR in the issue

@jonkoops
Copy link
Contributor Author

Created #10600, I'll close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants