fix(EmptyState): components no longer exported #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamviktora
reviewed
May 22, 2024
...f-codemods/src/rules/v6/emptyStateNonExportedComponents/emptyState-nonExported-components.ts
Outdated
Show resolved
Hide resolved
...f-codemods/src/rules/v6/emptyStateNonExportedComponents/emptyState-nonExported-components.ts
Outdated
Show resolved
Hide resolved
...emods/src/rules/v6/emptyStateNonExportedComponents/emptyState-nonExported-components.test.ts
Show resolved
Hide resolved
| type: "ImportSpecifier", | ||
| }, | ||
| { | ||
| message: `CustomHeader is no longer exported by PatternFly.`, |
There was a problem hiding this comment.
I wonder if saying something like: EmptyStateHeader (in your case CustomHeader) is no longer exported by PatternFly. would be better, but it's probably not worth the time spent on the change. I guess there won't be many (if any) consumers reexporting it like this and it still is good enough info imo.
thatblindgeye
force-pushed
the
iss638_esExports
branch
from
89a1a81
to
8f72511
Compare
adamviktora
approved these changes
May 28, 2024
wise-king-sullyman
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #638