Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design review / updates for react log viewer #63

Closed
1 of 3 tasks
dlabaj opened this issue Apr 24, 2024 · 3 comments · Fixed by #64
Closed
1 of 3 tasks

Design review / updates for react log viewer #63

dlabaj opened this issue Apr 24, 2024 · 3 comments · Fixed by #64
Assignees
@dlabaj @thatblindgeye
Milestone
Penta alpha omega...

Comments

@dlabaj
Copy link
Collaborator

dlabaj commented Apr 24, 2024 •
edited by andrew-ronaldson
Loading

The latest version of the first alpha was merged in this PR #60 It does require additional design review.

  • Alpha has been reviewed by design
  • Updates have been made to the UI per design review
  • Code reivew and tested

Link to surge site to review:

Surge preview
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 24, 2024
@dlabaj dlabaj added this to the 2024.Q2 milestone Apr 24, 2024
@dlabaj dlabaj self-assigned this Apr 24, 2024
@dlabaj dlabaj mentioned this issue Apr 24, 2024
Merged
@dlabaj dlabaj moved this from Needs triage to Not started in PatternFly Issues Apr 24, 2024
@andrew-ronaldson andrew-ronaldson moved this from Not started to In Progress in PatternFly Issues Apr 25, 2024
@andrew-ronaldson
Copy link

Just one small updates.
The search input in the demo looks like it is still PF 5. When I inspected everything still referenced v5 but that's the only one that didn't seem to be visually updated.
Screenshot 2024-04-25 at 10 22 28 AM

@andrew-ronaldson
Copy link

Screenshot 2024-04-25 at 10 33 14 AM
Sorry one other thing is the pause button should have a .pf-m-start class to add the xs spacer between the icon and the text in the button.

@thatblindgeye thatblindgeye mentioned this issue May 9, 2024
Merged
@thatblindgeye thatblindgeye linked a pull request May 9, 2024 that will close this issue
fix(v6): Resolved design feedback #64
Merged
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues May 9, 2024
@andrew-ronaldson andrew-ronaldson removed their assignment May 16, 2024
@nicolethoen
Copy link
Contributor

Closed by #64

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlabaj dlabaj

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha omega release
Development

Successfully merging a pull request may close this issue.

fix(v6): Resolved design feedback thatblindgeye/react-log-viewer
4 participants
@dlabaj @nicolethoen @andrew-ronaldson @thatblindgeye