feat(v6): consume v6 alphas #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
commented
Apr 1, 2024
| @@ -181,10 +182,10 @@ const ComplexToolbarLogViewer = () => { | |||
| isOpen={selectDataSourceOpen} | |||
| placeholderText={selectDataSourcePlaceholder} | |||
| > | |||
| {selectDataSourceMenu} | |||
| <SelectList>{selectDataSourceMenu}</SelectList> | |||
There was a problem hiding this comment.
With the new implementation of Select a SelectList component has to be manually passed in, otherwise SelectOptions will render as li in the DOM without an ul parent.
10 tasks
dlabaj
approved these changes
Apr 24, 2024
3 tasks
|
Added issue #63 to track any UI updates that are needed as part of migrating to v6. |
|
@andrew-ronaldson For this issue I created another issue #63 . When you have a chance can you take a look at the alpha v6 updates and see if there is anything that needs to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
Surge preview