Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v6): Resolved design feedback #64

Merged
merged 1 commit into from
May 20, 2024

Conversation

thatblindgeye
Copy link
Contributor

Closes #63

Surge preview

The search input in the demo should be using v6 styling so no changes made there.

@thatblindgeye thatblindgeye linked an issue May 9, 2024 that may be closed by this pull request
3 tasks
@andrew-ronaldson
Copy link

Thanks @thatblindgeye. The content above the log seems to have a different spacing from before.
Screenshot 2024-05-09 at 11 51 57 AM

@thatblindgeye
Copy link
Contributor Author

@andrew-ronaldson Would patternfly/patternfly-react#10343 be related to the spacing issue here? Seems like the align prop being used for this demo isn't working as intended anymore, which sounds like what's happening in 10343 from the React repo.

Copy link

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Nicole's issue to resolve the alignment I think this is good.

@nicolethoen nicolethoen merged commit 151d3c1 into patternfly:v6 May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design review / updates for react log viewer
3 participants