Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: add bundled genesis compact block to block processor #1706

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Aug 18, 2024

references prax-wallet/prax#161 and prax-wallet/prax#163

most of the changes in the diff are formatting, related to moving the core logic for processing a compact block into a dedicated processBlock method.

Copy link

changeset-bot bot commented Aug 18, 2024

🦋 Changeset detected

Latest commit: 6dc163d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@penumbra-zone/query Minor
@penumbra-zone/services Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TalDerei TalDerei self-assigned this Aug 18, 2024
@TalDerei TalDerei changed the title add bundled genesis compact block to block processor sync: add bundled genesis compact block to block processor Aug 19, 2024
@TalDerei TalDerei requested a review from grod220 August 19, 2024 15:52
Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do a lot of assurance testing for this. Added one more comment, but other than that, everything looks good to me.

turbocrime and others added 2 commits August 20, 2024 11:19
* add comment

* expand condition

---------

Co-authored-by: turbocrime <[email protected]>
@TalDerei TalDerei merged commit 94d2c8d into main Aug 20, 2024
6 checks passed
@TalDerei TalDerei deleted the quick-sync branch August 20, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants