Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: bundle genesis compact block into extension's static assets #163

Closed
wants to merge 6 commits into from

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Aug 18, 2024

references #161 and penumbra-zone/web#1706

Copy link

changeset-bot bot commented Aug 18, 2024

⚠️ No Changeset found

Latest commit: 9a6cb1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TalDerei TalDerei marked this pull request as draft August 18, 2024 06:37
@TalDerei TalDerei self-assigned this Aug 18, 2024
Comment on lines +40 to +41
? blockProcessor.sync(genesisBlock as JsonObject)
: blockProcessor.sync(),
Copy link
Contributor Author

@TalDerei TalDerei Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's building locally, but CI is currently failing because sync method in penumbra-zone/web#1706 was modified to optionally accept bundled genesis compact block.

@TalDerei TalDerei marked this pull request as ready for review August 18, 2024 16:12
@TalDerei TalDerei changed the title bundle genesis compact block into extension's static assets sync: bundle genesis compact block into extension's static assets Aug 19, 2024
@TalDerei TalDerei closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant