-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pre-release (EKS) kubernetes versions #70
Allow pre-release (EKS) kubernetes versions #70
Conversation
As described in helm/helm#9371, adding `-0` to the SemVer string allows pre-release versions to be included in the permitted versions. This is necessary for installing the chart on EKS.
Hmm, my understanding is:
|
@@ -1,7 +1,7 @@ | |||
apiVersion: v2 | |||
name: gcp-workload-identity-federation-webhook | |||
description: A Helm chart for gcp-workload-identity-federation-webhook | |||
kubeVersion: "^1.21.0" | |||
kubeVersion: "^1.21.0-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some comments and a link to helm/helm#9371 to describe the situation and why we need this workaround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, where do you mean for me to add comments? In the Chart or in the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean adding comments to the Chart.
Chart users would be able to understand why kubeVersion
includes -0
without navigating the Git history to this PR.
Yes this is correct. By using the tool vert, you can test the differences;
|
It may be possible to remove the |
As requested by @ordovicia in code review.
As described in helm/helm#9371, adding
-0
to the SemVer string allows pre-release versions to be included in the permitted versions. This is necessary for installing the chart on EKS.Closes #69