Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-release (EKS) kubernetes versions #70

Merged

Conversation

alanraison
Copy link
Contributor

As described in helm/helm#9371, adding -0 to the SemVer string allows pre-release versions to be included in the permitted versions. This is necessary for installing the chart on EKS.

Closes #69

As described in helm/helm#9371, adding `-0` to the SemVer string allows pre-release versions to be included in the permitted versions. This is necessary for installing the chart on EKS.
@ordovicia
Copy link
Contributor

Hmm, my understanding is:

  • v1.30.1-eks-1de2ab1 is a pre-release version. EKS should use v1.30.1+eks.1de2ab1 instead to stick to SemVer spec. Amazon and other cloud providers does not follow SemVer habitually.
  • Helm and other tools, by default, ignores pre-release versions when determining if a version is in a range. It is correct behavior in the light of SemVer semantics.
  • By adding -0 to SemVer range, we can make Helm count in pre-release versions.

@@ -1,7 +1,7 @@
apiVersion: v2
name: gcp-workload-identity-federation-webhook
description: A Helm chart for gcp-workload-identity-federation-webhook
kubeVersion: "^1.21.0"
kubeVersion: "^1.21.0-0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some comments and a link to helm/helm#9371 to describe the situation and why we need this workaround?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, where do you mean for me to add comments? In the Chart or in the PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean adding comments to the Chart.
Chart users would be able to understand why kubeVersion includes -0 without navigating the Git history to this PR.

@alanraison
Copy link
Contributor Author

Hmm, my understanding is:

  • v1.30.1-eks-1de2ab1 is a pre-release version. EKS should use v1.30.1+eks.1de2ab1 instead to stick to SemVer spec. Amazon and other cloud providers does not follow SemVer habitually.
  • Helm and other tools, by default, ignores pre-release versions when determining if a version is in a range. It is correct behavior in the light of SemVer semantics.
  • By adding -0 to SemVer range, we can make Helm count in pre-release versions.

Yes this is correct. By using the tool vert, you can test the differences;

> vert ^1.20.0 v1.30.2-eks-db838b0
> echo $?
1
> vert ^1.20.0-0 v1.30.2-eks-db838b0
1.30.2-eks-db838b0
> echo $?
0

@superbrothers
Copy link
Member

It may be possible to remove the kubeVersion itself. If we install Chart and it works fine, we can use it.

@ordovicia ordovicia merged commit 67dcd43 into pfnet-research:main Aug 19, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart kubeVersion refuses to install on EKS
3 participants