Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-release (EKS) kubernetes versions #70

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Allow pre-release (EKS) kubernetes versions #70

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b0adc1
Allow pre-release (EKS) kubernetes versions
alanraison Jul 21, 2024
e4b267e
Merge branch 'main' into allow-prerelease-kubeversions
ordovicia Aug 7, 2024
deacf75
fix: add explanation for kubeVersion format
alanraison Aug 15, 2024
b3d9f59
fix: typo
alanraison Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/gcp-workload-identity-federation-webhook/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: gcp-workload-identity-federation-webhook
description: A Helm chart for gcp-workload-identity-federation-webhook
kubeVersion: "^1.21.0"
kubeVersion: "^1.21.0-0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some comments and a link to helm/helm#9371 to describe the situation and why we need this workaround?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, where do you mean for me to add comments? In the Chart or in the PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean adding comments to the Chart.
Chart users would be able to understand why kubeVersion includes -0 without navigating the Git history to this PR.

home: https://github.com/pfnet-research/gcp-workload-identity-federation-webhook/
# A chart can be either an 'application' or a 'library' chart.
#
Expand Down
Loading